On Thu, 17 Mar 2011, Jesper Juhl wrote:
> On Thu, 17 Mar 2011, Nicholas A. Bellinger wrote:
>
> > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
> >
>
> Minor nitpicks below.
>
>
...
>
> > +int chap_server_compute_md5(
> > + struct iscsi_conn *conn,
> > + struct iscsi_node_auth *auth,
> > + char *NR_in_ptr,
> > + char *NR_out_ptr,
> > + unsigned int *NR_out_len)
> > +{
> > + char *endptr;
> > + unsigned char id, digest[MD5_SIGNATURE_SIZE];
> > + unsigned char type, response[MD5_SIGNATURE_SIZE * 2 + 2];
> > + unsigned char identifier[10], *challenge, *challenge_binhex;
>
> If you changed the above line to
>
> unsigned char identifier[10], *challenge;
> unsigned char *challenge_binhex = 0;
>
Actually, to be pedantic, that should probably be
unsigned char *challenge_binhex = NULL;
--
Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
