>-----Original Message----- >From: Mike Christie [mailto:michaelc@xxxxxxxxxxx] >Sent: Tuesday, March 15, 2011 3:26 AM >To: Vikas Chaudhary >Cc: James Bottomley; linux-scsi@xxxxxxxxxxxxxxx; Lalit Chandivade; Ravi >Anand; Karen Higgins >Subject: Re: [PATCH 04/13] qla4xxx: cleanup DDB relogin logic during >initialization > >On 03/14/2011 12:24 AM, Vikas Chaudhary wrote: >> diff --git a/drivers/scsi/qla4xxx/ql4_init.c >b/drivers/scsi/qla4xxx/ql4_init.c >> index 22fc57e..bf1c30b 100644 >> --- a/drivers/scsi/qla4xxx/ql4_init.c >> +++ b/drivers/scsi/qla4xxx/ql4_init.c >> @@ -723,13 +723,38 @@ int qla4_is_relogin_allowed(struct scsi_qla_host >*ha, uint32_t conn_err) >> return relogin; >> } >> >> +static void qla4xxx_flush_AENS(struct scsi_qla_host *ha) >> +{ > >I think it is ok for now since the patch is moving the old function, but >in some future coding style cleanup patch could you fix mixed cases like >this. So it would be qla4xxx_flush_aens instead of _AENS. It then >matches the kernel coding style and matches functions like >qla4xxx_process_aen. > Ok, we will take care from next time. This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
