> From: Jack Wang [mailto:jack_wang@xxxxxxxxx] > Sent: Sunday, March 13, 2011 6:22 AM > To: Chuck Tuffli; linux-scsi@xxxxxxxxxxxxxxx > Subject: RE: [RFC PATCH 1/1] libsas: Add data integrity support > > > From: Chuck Tuffli <chuck_tuffli@xxxxxxxxxxxxxx> > > > > This patch adds Data Integrity support to libsas > > > > Signed-off-by: Chuck Tuffli <chuck_tuffli@xxxxxxxxxxxxxx> > > --- > > > > diff --git a/drivers/scsi/libsas/sas_scsi_host.c > > b/drivers/scsi/libsas/sas_scsi_host.c > > index 2119871..91c6afe 100644 ... > > @@ -152,6 +178,10 @@ static struct sas_task *sas_create_task(struct > > scsi_cmnd *cmd, > > task->ssp_task.task_attr = TASK_ATTR_SIMPLE; > > memcpy(task->ssp_task.cdb, cmd->cmnd, 16); > > > > + task->prot = scsi_get_prot_op(cmd); > > + task->prot_sg = scsi_prot_sglist(cmd); > > + task->prot_num_scatter = scsi_prot_sg_count(cmd); > > + > [Jack Wang] Should we also save prot_type into a field in task? > Others looks fine. > Reviewed-by: Jack Wang <jack_wang@xxxxxxxxx> Agreed. I'll generate a version 2 of the patch. Thanks for the review. ---chuck -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
