On 02/24/2011 05:27 PM, Dan Williams wrote: > On Tue, Feb 22, 2011 at 12:16 PM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote: >> From: Dave Jiang <dave.jiang@xxxxxxxxx> >> >> Moving the probe_roms_32 code to probe_roms and make available for all x86. The >> end result adapter roms data structure is made available read-only to drivers. >> The Intel isci SAS driver needs to scan the OROM memory in order to pull OEM >> parameters from the OROM. >> >> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> >> Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx> >> --- >> >> We could just export adapter_rom_resources directly and be done with it, but >> it seemed reasonable to have a compile time catch for drivers that try to >> modify the resources, and that drivers should not assume the number of >> available adapter roms. >> > > Ping? The "RFC" was probably not needed, just wanted clarification if > the interface for modules to retrieve the adapter rom data was in good > taste. > Rather than exporting the array -- which is functionally what you're doing -- I would prefer if the actual probing code can be generalized and put into probe_roms.c. Extra bonus if it can be unified with the existing probing code. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
