On 02/20/2011 03:22 AM, adam radford wrote: > James/Linux-scsi, > > The following patch for megaraid_sas fixes megasas_probe_one() to > clear MSI-X flags in kdump when the 'reset_devices' kernel parameter > is passed in. > This is actually the one bit where I'm quite puzzled by. Problem here is the pci_enable_msix() actually fails when MSI-X is already enabled. Which is odd, given that MSI-X _is_ enabled already, so taken at face value pci_enable_msix() shouldn't fail here. I know that there are several stages to the MSI-X initialisation, so this is the safe route here. But I also have seen _LOTS_ of failures with kdump and raid HBAs, most of which point to the same problem here. Can't we put in a 'force' parameter to pci_enable_msix() to avoid having to code this one in each and every driver? Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
