Re: [RFC PATCH 1/6] isci: initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +irqreturn_t isci_isr(int vec, void *data)
> +{
> +	struct isci_host *isci_host
> +		= (struct isci_host *)data;
> +	struct scic_controller_handler_methods *handlers
> +		= &isci_host->scic_irq_handlers[SCI_MSIX_NORMAL_VECTOR];
> +	irqreturn_t ret = IRQ_NONE;

> +	if (isci_host_get_state(isci_host) != isci_starting
> +	    && handlers->interrupt_handler) {

Also there should be no need for a state check here.  register_irq
must not happen before you're ready to handle the interrupt.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux