On Sun, 13 Feb 2011 14:43:00 -0800 "Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx> wrote: > On Sun, 2011-02-13 at 09:24 +0100, Fubo Chen wrote: > > Check LUN before reading from device_list[] array. > > > > Signed-off-by: Fubo Chen <fubo.chen@xxxxxxxxx> > > --- > > drivers/target/target_core_device.c | 13 +++++++++++++ > > 1 file changed, 13 insertions(+), 0 deletions(-) > > > > I think this is a reasonable check to add considering the number of TCM > fabric modules calling transport_get_lun_for_[cmd,tmr]() directly. > > Note this patch did not apply cleanly because of the extra BUG_ON() in > transport_get_lun_for_cmd(), but has been fixed + committed as > 0f75d7cf4b259. I think that we need the mechanism that enable target drivers to limit the maximum lun. Also TRANSPORT_MAX_LUNS_PER_TPG, 256, sounds too small. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
