RE: [PATCH] mpt2sas: fix a compile issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I have verified this patch and it is valid changes.
Tomas, Thanks for providing the patch. 

Please consider this as an ACKed patch.

~ Kashyap

> -----Original Message-----
> From: Tomas Henzl [mailto:thenzl@xxxxxxxxxx]
> Sent: Thursday, February 03, 2011 8:11 PM
> To: 'linux-scsi@xxxxxxxxxxxxxxx'
> Cc: Desai, Kashyap; 'James.Bottomley@xxxxxxxxxxxxxxxxxxxxx'; Prakash,
> Sathya
> Subject: [PATCH] mpt2sas: fix a compile issue
> 
> Without CONFIG_SCSI_MPT2SAS_LOGGING defined the
> variable mpi_reply isn't defined.
> 
> This patch moves the #endif below the expression where
> the mpi_reply is used.
> 
> Signed-off-by: Tomas Henzl <thenzl@xxxxxxxxxx>
> 
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> index eda347c..40b57c6 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> @@ -2741,13 +2741,14 @@ _scsih_sas_control_complete(struct
> MPT2SAS_ADAPTER *ioc, u16 smid,
>  #ifdef CONFIG_SCSI_MPT2SAS_LOGGING
>  	Mpi2SasIoUnitControlReply_t *mpi_reply =
>  	    mpt2sas_base_get_reply_virt_addr(ioc, reply);
> -#endif
> +
>  	dewtprintk(ioc, printk(MPT2SAS_INFO_FMT
>  	    "sc_complete:handle(0x%04x), (open) "
>  	    "smid(%d), ioc_status(0x%04x), loginfo(0x%08x)\n",
>  	    ioc->name, le16_to_cpu(mpi_reply->DevHandle), smid,
>  	    le16_to_cpu(mpi_reply->IOCStatus),
>  	    le32_to_cpu(mpi_reply->IOCLogInfo)));
> +#endif
>  	return 1;
>  }
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux