Re: [v2 PATCH 4/5] bnx2fc: Broadcom FCoE Offload driver submission - part 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/02/2011 09:42 PM, Bhanu Gollapudi wrote:

Actually you do not have to wait for the scsi eh to run, right. It
looks
like bnx2fc would log out the port, which ends up calling
fc_remote_port_delete and that would cause the fc timed out function
to
return BLK_EH_RESET_TIMER to prevent the scsi eh from running. Is
that
right? That type of eh strategy behavior seems like something you
want
to sync up with libfc or the fc class so all drivers do something
similar.

As per FCP-4, if the ABTS times out, we will have to explicitly LOGO the

What section is that in?

target and relogin back. If we rely on 60 sec eh_abort_handler, and if
ABTS times out, SCSI error handling will go to LUN RESET, TGT reset
path, which is a generic error handling than transport specific error
handling.

If that is right, then it seems the other FC drivers are doing it wrong then, and you hit that problem if someone sets the scsi cmd timer lower than BNX2FC_IO_TIMEOUT. If that is right, that just does not seem right to hack around the issue in the driver too.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux