(cc'ing Kay) Hello, On Tue, Feb 01, 2011 at 03:55:14PM +0100, Hannes Reinecke wrote: > seeing that you are moving the old SCSI / libata AEN handling over > to the new block-based workqueue, I was wondering what your plans > are with the remaining SDEV_EVT_* things. SDEV_EVT_* are basically dead. There's no valid user for it in the kernel. libata-scsi hasn't been converted yet - virtually SATA AN is pretty much stillborn and converting it would require a way to map ATA device to block device which isn't easy without changing SCSI. > Thing is I'm currently working on implementing proper Unit Attention > handling in the SCSI stack. For this I would need to have some field > off the scsi_device structure into which I can store information > about which events / event types are supported and which are activated. > So the existing bitmap approach with 'supported_events' would quite > a good starting point here, and it will even be useful to add > another one, eg 'enabled_events'. > And, of course, plan is to route appropriate events over to the > block workqueue by calling disk_check_events(). > > Unless you have other ideas/plans here ... So, I think using the block layer DISK_EVENT_* would be the right way to do it, but what kind of events do you have on mind? -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html