On Sat, 2011-01-29 at 12:18 -0800, James Bottomley wrote: > On Sat, 2011-01-29 at 10:36 -0800, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > > > This patch makes proc_mkdir() and remove_proc_entry() use a NULL > > parameter to fix the following sparse warning: > > > > CHECK drivers/target/target_core_configfs.c > > drivers/target/target_core_configfs.c:3131:54: warning: Using plain integer as NULL pointer > > drivers/target/target_core_configfs.c:3145:50: warning: Using plain integer as NULL pointer > > drivers/target/target_core_configfs.c:3212:42: warning: Using plain integer as NULL pointer > > > > Reported-by: Fubo Chen <fubo.chen@xxxxxxxxx> > > Signed-off-by: Nicholas A. Bellinger <nab@xxxxxxxxxxxxxxx> > > (cherry picked from commit d83fca37fa4a6c2bcb2806800f221528a76fc080) > > Firstly, don't use git-cherry-pick -x ... it adds spurious information > like this that I have to edit out manually. > Er sorry, these should have been stripped out before sending. I will make sure these are removed for next series. > Secondly, if, as you said, you're transitioning to debugfs based > interfaces, don't do this, just strip the /proc based interface from > mainline. > Well, I would like them to eventually go into individual target_core_configfs.c and target_core_fabric_configfs.c context specific attributes, but we need to address the PAGE_SIZE limitiation in configfs/sysfs attribute output before this can be done. This was briefly discussed here: http://marc.info/?l=linux-scsi&m=129590246906137&w=2 In the mean time having proper SCSI MIB read-only statistics is still very important for-38, so please consider this minor patch. Thanks, --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
