This is a cleanup and not a bugfix. container_of() does pointer math and the result of that math can basically not be NULL here so "se_dev" is non-NULL. Normally release() type functions accept a NULL parameter. I don't think target_core_dev_release() is ever called with a NULL parameter but it's a cleaner to allow that. So instead of checking "se_dev", I've changed it to check "item". Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index 2764510..d9dcd9d 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c @@ -1973,7 +1973,7 @@ static void target_core_dev_release(struct config_item *item) struct se_subsystem_dev, se_dev_group); struct config_group *dev_cg; - if (!(se_dev)) + if (!item) return; dev_cg = &se_dev->se_dev_group; -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
