> > On Mon, 2011-01-24 at 14:57 +0100, Tejun Heo wrote: > > pm8001 manages its own list of pending works and cancel them on device > > free. It is unnecessarily complex and has a race condition - the > > works are canceled but not synced, so the work could still be running > > during and after the data structures are freed. > > > > This patch simplifies workqueue usage. > > > > * A driver specific workqueue pm8001_wq is created to serve these > > work items. > > > > * To avoid confusion, the "queue" suffixes are dropped from work items > > and functions. > > > > * Delayed queueing was never used. pm8001_work now uses work_struct > > instead. > > > > * The driver no longer keeps track of pending works. All pm8001_works > > are queued to pm8001_wq and the workqueue is flushed as necessary. > > > > flush_scheduled_work() usage is removed during conversion. > > cc'ing pm8001 maintainers for an opinion. Jack could you look at this > and ack, please. > > Thanks, > > James > [Jack Wang] Looks Okay to me. Ack-by: Jack Wang <jack_wang@xxxxxxxxx> Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
