Re: [PATCH] target: Fix tcm_mod_builder.py default EXTRA_CFLAGS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-01-18 at 22:36 +0100, Christoph Hellwig wrote:
> On Tue, Jan 18, 2011 at 01:30:22PM -0800, Nicholas A. Bellinger wrote:
> > +	buf = "EXTRA_CFLAGS += -I$(srctree)/include/ -I$(srctree)/drivers/target/" + fabric_mod_name + "\n\n"
> 
> -I$(srctree)/include/ is never needed, that's added automatically.
> Similarly adding the directory of the driver itself (assuming that's
> what the second one is supposed to be) is not needed either.
> 

This is correct on the -I$(srctree)/include/, and I will drop this as
well..  However with the current fabric module include layout (all .h
living in drivers/target/$FABRIC_MOD), the latter bit is still required
AFAICS to build.

--nab



--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux