Hey, Jeff. On Wed, Jan 12, 2011 at 01:35:07PM -0500, Jeff Garzik wrote: > The previous patch breaks READ VERIFY translation for all cases > -except- this one. Ooh, right; then, can we just fix that? > The bottom line is that this patch simply wants to trigger an ATA > command, and return immediately, discarding the command results. > I'm not even sure a "run this command in background, and discard > results" facility requires the EH. It doens't necessarily require EH but the dependency is rather delicate because we still ride on SCSI EH. For example, we don't have any provision for running qc's without the associated scmd. If the command fails, libata EH rides on SCSI EH and the interaction relies on the association between qc's and scmd's. We may be able to add privison for this case but we already have working mechanism in EH for internal commands so it's just easiser that way. Well, actually, the _really_ right(eous) thing to do here would be just not doing it as it's an ugly hack no matter which way we spin it, but this has a quite significant impact on resume from STR latency so... Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
