On Wed, 2011-01-05 at 12:52 -0800, James Bottomley wrote: > On Wed, 2011-01-05 at 12:44 -0800, Eddie Wai wrote: > > Hello, > > > > This patch set contains two fixes and added various features as titled. > > The two fixes are: > > 1 - connection cleanup fix which fixes a chip panic issue > > 2 - nopout LUN field fix which fixes nopout timeouts > > So the immediate question is do these need backporting to earlier > kernels via the stable tree (in which case a cc: stable@xxxxxxxxxx tag > would be needed)? Both bugs have been present in the code for quite a while. I think its just recently that they got exposed. The severity of the chip panic is higher as the chip will need to be reset to recover. But it's not easy to trigger this and was found only by our PQA doing extraordinary tests. The nopout LUN bug is more common and will hamper I/O performance if the nopout LUN field is not 32-bit symmetric. But the result is not catastrophic. I would recommend having these be backported to the stable tree if possible. Let me know if you want to move forward with the stable tree patch. Thanks. > > James > > > > The features added includes TCP timestamp, jumbo MTU, text pdu support > > for discovery offload, and 57712(E) support. > > > > Please review. Thanks. > > Eddie > > > > Eddie Wai (8): > > BNX2I: Allow ep CONNECT_FAILED condition to go through proper cleanup > > BNX2I: Fixed the 32-bit swapping of the LUN field for nopouts for > > 5771X > > BNX2I: Added handling for unsupported iSCSI offload hba > > BNX2I: Added support for the 57712(E) devices > > BNX2I: Added TCP timestamps option support > > BNX2I: Added jumbo MTU support for the no shost case > > BNX2I: Added iSCSI text pdu support for iSCSI offload > > BNX2I: Updated to version 2.6.2.3 > > > > drivers/net/bnx2x/bnx2x_main.c | 7 -- > > drivers/scsi/bnx2i/bnx2i.h | 5 +- > > drivers/scsi/bnx2i/bnx2i_hwi.c | 122 +++++++++++++++++++++++++++++++++++++- > > drivers/scsi/bnx2i/bnx2i_init.c | 33 ++++++++-- > > drivers/scsi/bnx2i/bnx2i_iscsi.c | 10 +++- > > include/linux/pci_ids.h | 2 + > > 6 files changed, 160 insertions(+), 19 deletions(-) > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html