Oh, I did have one minor comment I forgot about: > + struct ib_cq *send_cq ____cacheline_aligned; This could actually be ____cacheline_aligned_in_smp I think, not that it matters at all in practice (although maybe someone will build a 1-core embedded initiator on a memory-constrained system someday??) - R. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html