On 01/05/2011 11:36 AM, James Bottomley wrote:
> On Wed, 2011-01-05 at 10:39 -0500, Peter Jones wrote:
>> Previously we were using strncmp in order to avoid having to include
>> whitespace in the devlist, but this means "HSV1000" matches a device
>> list entry that says "HSV100", which is wrong. This patch adds
>> scsi_dh_strcmp(), which checks that any trailing characters in string 2
>> are the pad character 0x20.
>
> Hmm, the cockup comes from dh rolling its own comparators. Could you
> just convert it to use the standard ones in scsi_devinfo.c? There's an
> example of how to do this in scsi_transport_spi.c
Oh, sure. Thanks for the pointer.
--
Peter
THE MAGIC WORDS ARE SQUEAMISH OSSIFRAGE
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
