On Monday 20
> +#define TRUE 1
> +#define FALSE 0
can't you use 'true' or 'false'?
.. snip..
> +static int scst_local_get_sas_transport_id(struct scst_local_sess *sess,
> + uint8_t **transport_id, int *len)
> +{
> + int res = 0;
> + int tr_id_size = 0;
> + uint8_t *tr_id = NULL;
> +
> + tr_id_size = 24; /* A SAS TransportID */
> +
> + tr_id = kzalloc(tr_id_size, GFP_KERNEL);
> + if (tr_id == NULL) {
> + PRINT_ERROR("Allocation of TransportID (size %d) failed",
> + tr_id_size);
pr_err? Or is this based on a module parameter?
> + res = -ENOMEM;
> + goto out;
> + }
> +
> + tr_id[0] = 0x00 | SCSI_TRANSPORTID_PROTOCOLID_SAS;
Hmm, why the 0x00? Can't you just do an assigment?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
