On Mon, 2010-12-27 at 16:50 +0100, Bart Van Assche wrote: > On Thu, Dec 23, 2010 at 10:31 PM, David Dillow <dillowda@xxxxxxxx> wrote: > > We use req->scmnd != NULL to indicate an active request, so there's no > > need to keep a separate list for them. We can afford the array iteration > > during error handling, and dropping it gives us one less item that needs > > lock protection. > > [ ... ] > > Before this patch a request was either on the free_reqs list or on the > req_queue list. After this patch has been applied a request is either > on the free_reqs list or not on any list. So it doesn't make sense > anymore to invoke list_move_tail() from srp_remove_req() - that > function should be modified such that it invokes list_add_tail(). And > once that is done the list_del_init() call added by this patch can be > replaced by a list_del() call. Good suggestion. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
