Hi,
A 'kfree(karg)' is missing in a failure path in
drivers/message/fusion/mptctl.c::mptctl_getiocinfo() which can cause a
memory leak. This patch should take care of that.
Hope I didn't miss something obvious, but to me it looks like adding this
kfree() is the right thing to do. If you disagree feel free to correct me
:-)
Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
---
mptctl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
compile tested only since I don't have proper hardware to test for real.
diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c
index a3856ed..1dcc13a 100644
--- a/drivers/message/fusion/mptctl.c
+++ b/drivers/message/fusion/mptctl.c
@@ -1307,8 +1307,10 @@ mptctl_getiocinfo (unsigned long arg, unsigned int data_size)
else
karg->adapterType = MPT_IOCTL_INTERFACE_SCSI;
- if (karg->hdr.port > 1)
+ if (karg->hdr.port > 1) {
+ kfree(karg);
return -EINVAL;
+ }
port = karg->hdr.port;
karg->port = port;
--
Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
