On Thu, Dec 23, 2010 at 1:05 PM, James Bottomley <James.Bottomley@xxxxxxx> wrote: > On Thu, 2010-12-23 at 11:34 -0800, Chuck Tuffli wrote: >> Can some shed light on why sas_ata_phy_reset() does an I_T nexus >> reset? It seems like calling sas_phy_reset() might be more accurate in >> this case. Thanks. > > It needs an ATA reset that propagates. ATA resets don't key off SAS phy > resets, they have a separate reset sequence, which is triggered by the > I_T nexus reset. Maybe this is a misunderstanding on my part, but I thought there were two ways to reset ATA devices connected to SAS/SMP: - SRST FIS or - issuing a link reset via LOCAL_PHY_CONTROL / SMP_PHY_CONTROL Since sas_phy_reset() triggers the second case and three of the SAS drivers (aic94xx, mvsas, pm8001) all internally call sas_phy_reset() as a part of the I_T nexus reset, it seemed like this was a more direct and consistent approach. ---chuck -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
