On Thu, 2010-12-16 at 07:00 -0700, Matthew Wilcox wrote: > On Thu, Dec 16, 2010 at 05:44:58AM -0500, Christoph Hellwig wrote: > > On Wed, Dec 15, 2010 at 10:02:57PM -0700, Matthew Wilcox wrote: > > > > > > I thought I'd take a crack at removing the host lock from uas. I think > > > I can now switch to using GFP_NOIO (since interrupts are enabled by > > > scsi_request_fn()), and I have to use _irq spinlocks to protect the list > > > that is modified from interrupt context (same reason :-). > > > > ->qeuecommand can be called from software interrupt context, so you'll > > need to stick to GFP_ATOMIC. > > Ah, I couldn't find a path that did that. Could you point it out to me? > I'll send a patch to update that documentation. Well, the documentation (scsi_mid_low_api.txt) says this. The reason is the blk_run_queue in softirq context. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html