On Thu, 2010-12-09 at 01:20 +0900, Namhyung Kim wrote: > 2010-12-08 (ì), 02:24 +0900, Namhyung Kim: > > 2010-12-07 (í), 10:30 -0600, James Bottomley: > > > On Wed, 2010-12-08 at 01:12 +0900, Namhyung Kim wrote: > > > > MODULE_DEVICE_TABLE expands to nop when !MODULE (not !CONFIG_MODULE) so > > > > allyesconfig build always emits the warnings. Possible patch for this > > > > would be wraping it up in #ifdefs but when I sent a same patch to Greg > > > > KH he didn't want to add more #ifdefs in .c files. > > > > > > I didn't mean changing any c files. I meant fixing the module include > > > to make the table used even in the !MODULE case. That way we only alter > > > one file instead of a significant proportion of the drivers. > > > > > > > It would not be a _significant_ proportion because normal drivers may > > refer the table in their driver struct. :) > > > > Anyway the patch below looks good to me. I'll happily drop my patches if > > you apply this in your tree. > > > > Hi, > > As akpm told me, using DEFINE_PCI_DEVICE_TABLE could also remove the > warnings (probably by making the table const) but it still requires > modifying .c files. What do you think? The warning only appears in the non-modular case, which is pretty unusual for drivers nowadays, so I think the simplest elimination solution is the best one (i.e. just kill it at source in the header). James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
