On Mon, 2010-12-06 at 10:36 +0100, Lukas Kolbe wrote: > On Mon, 2010-12-06 at 09:59 +0200, Kai Makisara wrote: > > On Thu, 2 Dec 2010, Kai Makisara wrote: > > > OK, today I have had some time (national holiday). I think I have tracked > > down this problem. The patch at the end should fix it. Basically, > > normalize_buffer() needs to know the order of the pages in order to > > properly free the pages and update the buffer size. When allocation > > failed, the order was not yet stored into the tape buffer definition. This > > does explain the problem after allocation failed. > > Thank you, this does indeed look nasty (like a not easily catched bug). > > > Why allocation failed is another problem which has been discussed elsewhere. > > I just tonight discovered that Debian's .config has > CONFIG_FUSION_MAX_SGE=40. Right now I'm testing with the mptsas' drivers > maximum of 128 and see if I can reproduce the failure under memory > pressure again. Sorry for not catching this one earlier! After reading > the source, I had the assumption that it already was 128 ... Debian has since fixed to the new default value here, and after a few days of testing with CONFIG_FUSION_MAX_SGE=128 and your patch I wasn't able to reproduce the failure anymore! Kind regards, Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
