On 2010-11-26 01:37, Martin K. Petersen wrote: >>>>>> "Jens" == Jens Axboe <jaxboe@xxxxxxxxxxxx> writes: > > Jens> Great, the two different values and needing to sync them was > Jens> horrible. What kind of testing did you do? Have to be a little > Jens> extra careful at this point. > > Yeah, we should probably let it soak a bit in -next just to make sure. > > There really aren't many devices from this millennium that don't support > clustering. Which I guess is why we haven't seen any problems. > > I ended up disabling clustering in one of the FC drivers to test with a > real workload. Threw in a BUG_ON(nsegs > queue_max_segments(q)) for good > measure. > > I also tested mixing and matching clustered and non-clustered bottom > devices while stacking with DM. > > New version below, fixing the things you and Matthew pointed out... Thanks applied. Small plea for the future - please rewrite the subject line to indicate a v2 (or whatever) of the patch. That will make them harder to miss. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
