Ben, I also don't find out the negative for the original define. Thanks, Bo Yang -----Original Message----- From: Ben Hutchings [mailto:ben@xxxxxxxxxxxxxxx] Sent: Saturday, November 27, 2010 4:37 PM To: James E.J. Bottomley Cc: DL-MegaRAID Linux; linux-scsi@xxxxxxxxxxxxxxx Subject: [PATCH] [SCSI] megaraid_sas: Declare poll_aen_lock as static There is no reason for this to be extern. Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> --- drivers/scsi/megaraid/megaraid_sas.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.c b/drivers/scsi/megaraid/megaraid_sas.c index 7451bc0..7050a88 100644 --- a/drivers/scsi/megaraid/megaraid_sas.c +++ b/drivers/scsi/megaraid/megaraid_sas.c @@ -115,7 +115,7 @@ static u32 megasas_dbg_lvl; static u32 support_device_change; /* define lock for aen poll */ -spinlock_t poll_aen_lock; +static spinlock_t poll_aen_lock; static void megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd, -- 1.7.2.3 -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse. ÿô.nÇ·®+%˱é¥wÿº{.nÇ·¥{±þÇø¡Ü}©²ÆzÚj:+v¨þø®w¥þàÞ¨è&¢)ß«a¶Úÿûz¹ÞúÝjÿwèf