On Mon, 2010-11-29 at 17:41 +0100, Christoph Hellwig wrote:
> On Sat, Nov 27, 2010 at 11:17:36PM -0800, Nicholas A. Bellinger wrote:
> > /**
> > - * megasas_get_cmd - Get a command from the free pool
> > + * __megasas_get_cmd - Get a command from the free pool
> > * @instance: Adapter soft state
> > *
> > * Returns a free command from the pool
> > + * Locking: Called with instance->cmd_pool_lock w/ spin_lock_irqsave
> > */
> > -static struct megasas_cmd *megasas_get_cmd(struct megasas_instance
> > - *instance)
> > +static struct megasas_cmd *
> > +__megasas_get_cmd(struct megasas_instance *instance)
> > {
> > + struct megasas_cmd *cmd;
> > unsigned long flags;
> > - struct megasas_cmd *cmd = NULL;
> >
> > spin_lock_irqsave(&instance->cmd_pool_lock, flags);
>
> --- snip ---
>
> > +static struct megasas_cmd *
> > +megasas_get_cmd(struct megasas_instance *instance)
> > +{
> > + struct megasas_cmd *cmd;
> > + unsigned long flags;
> > +
> > + spin_lock_irqsave(&instance->cmd_pool_lock, flags);
>
> I can't see how this works.
>
Ugh, I had to recode patch #3 after accidently git resetting on the
wrong branch..
Thanks alot for spotting this, fixed with:
[lock_less-LLDs-for-38-v2 13a4cd2] megaraid_sas: Remove bogus hba_lock __megasas_get_cmd()
1 files changed, 0 insertions(+), 3 deletions(-)
Thanks!
--nab
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
