Re: [PATCH (trivial) 1/2] SCSI: improve two error messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 15 Nov 2010, Alan Stern wrote:

> This trivial patch (as1338) makes two uninformative error messages in
> scsi_sysfs_add_sdev() more explicit.
> 
> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> 
> ---
> 
> Index: usb-2.6/drivers/scsi/scsi_sysfs.c
> ===================================================================
> --- usb-2.6.orig/drivers/scsi/scsi_sysfs.c
> +++ usb-2.6/drivers/scsi/scsi_sysfs.c
> @@ -890,13 +890,15 @@ int scsi_sysfs_add_sdev(struct scsi_devi
>  	device_enable_async_suspend(&sdev->sdev_gendev);
>  	error = device_add(&sdev->sdev_gendev);
>  	if (error) {
> -		printk(KERN_INFO "error 1\n");
> +		sdev_printk(KERN_INFO, sdev,
> +				"failed to add device: %d\n", error);
>  		return error;
>  	}
>  	device_enable_async_suspend(&sdev->sdev_dev);
>  	error = device_add(&sdev->sdev_dev);
>  	if (error) {
> -		printk(KERN_INFO "error 2\n");
> +		sdev_printk(KERN_INFO, sdev,
> +				"failed to add class device: %d\n", error);
>  		device_del(&sdev->sdev_gendev);
>  		return error;
>  	}

This doesn't seem to be present in linux-next as of today, so I have 
merged it to trivial queue.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux