On Tue, 2010-11-23 at 17:31 -0500, Christoph Hellwig wrote: > plain text document attachment (kill-se_transform_info) > No quite sure what the original use was, but these days it's almost > completely superflous. Besides the two different ways to pass the > se_device that can also be retreived from the se_cmd it only contained > a set_counts flag for transport_generic_get_cdb_count, which can more > easily be passed directly. > This is a long overdue cleanup committed as 2e7d255302, great stuff. ;) Also just to clarify, the se_transform_info was a historical reminent used by SCF_SCSI_DATA_SG_IO_CDB cmds in order to support the v2.x legacy iSCSI RAID1 w/ so that individual se_tasks could be directed to different se_devices from a single received se_lun -> se_cmd. Which brings the total for the series tested this evening against TCM_loop and LIO-Target ports on .37-rc2 x86 KVM with IBLOCK, PSCSI, FILEIO and IBLOCK backends. Pushing into lio-core-2.6.git now.. drivers/target/lio-target/iscsi_target_core.h | 1 - drivers/target/lio-target/iscsi_target_mib.h | 1 - drivers/target/target_core_alua.h | 2 - drivers/target/target_core_configfs.c | 65 +++------ drivers/target/target_core_device.c | 18 +-- drivers/target/target_core_file.c | 27 +--- drivers/target/target_core_file.h | 2 - drivers/target/target_core_hba.c | 180 ++++++++++------------ drivers/target/target_core_hba.h | 11 +- drivers/target/target_core_iblock.c | 23 +--- drivers/target/target_core_iblock.h | 2 - drivers/target/target_core_mib.c | 3 - drivers/target/target_core_mib.h | 2 - drivers/target/target_core_pscsi.c | 11 +- drivers/target/target_core_pscsi.h | 2 - drivers/target/target_core_rd.c | 30 +---- drivers/target/target_core_rd.h | 2 - drivers/target/target_core_stgt.c | 9 +- drivers/target/target_core_stgt.h | 2 - drivers/target/target_core_transport.c | 207 +++++-------------------- include/target/target_core_base.h | 38 ----- include/target/target_core_configfs.h | 2 - include/target/target_core_device.h | 2 - include/target/target_core_tpg.h | 2 - include/target/target_core_transport.h | 15 +-- 25 files changed, 163 insertions(+), 496 deletions(-) Thanks Christoph! --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
