On 11/18/2010 12:37 AM, Christoph Hellwig wrote: > On Wed, Nov 17, 2010 at 02:29:30PM -0800, Nicholas A. Bellinger wrote: >> Hmmm, this is following jgarzik's recommendation for LLDs that we could >> not immediately identify a internal spin_lock to disable interrupts >> upon. (eg: not libiscsi and libata). > > In that case wait for the driver author to identify it. If there's > no maintainer in reach chance is the driver doesn't care about the push > down. No need to rush any of this, do it one driver at a time and get > it right. I totally agree with Christoph. Patches 5, 6, 8, 11 all change behaviour I would like to see an "I audit the driver and ..." Please see my comment to [patch 6] Do it one by one and open-code the local_irq_save/restore inside the main function. It's not like you can get away from a total audit and testing. Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
