On Wed, 2010-11-17 at 17:32 -0500, Christoph Hellwig wrote: > On Wed, Nov 17, 2010 at 02:21:59PM -0800, Nicholas A. Bellinger wrote: > > On Wed, 2010-11-17 at 16:38 -0500, Christoph Hellwig wrote: > > > There is no need for the transport_cdb_transform function pointer, > > > we can simply call the right code based on the cmd flags. > > > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > > > > > Hmmm, it is really less expensive to drop cmd->transport_cdb_transport() > > and change transport_generic_new_cmd() to require 4 bitwise AND instructions > > for each bulk SCF_SCSI_DATA_SG_IO_CDB cmd..? > > The pointer bloats every single command in flight, and CPU time is > getting really cheap these days. Either way this will get much simpler > after a few more patches. See the next one for a first preview. > Committed as f71d81ec15. Thanks! > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
