The check of the result of scsi_normalize_sense is incorrect, since it is up set down. And it looks more like a typo. Signed-off-by: Hillf Danton <dhillf@xxxxxxxxx> --- --- a/drivers/scsi/device_handler/scsi_dh_emc.c 2010-11-01 19:54:12.000000000 +0800 +++ b/drivers/scsi/device_handler/scsi_dh_emc.c 2010-11-16 20:50:36.000000000 +0800 @@ -128,7 +128,7 @@ static int trespass_endio(struct scsi_de int err = SCSI_DH_IO; struct scsi_sense_hdr sshdr; - if (!scsi_normalize_sense(sense, SCSI_SENSE_BUFFERSIZE, &sshdr)) { + if (scsi_normalize_sense(sense, SCSI_SENSE_BUFFERSIZE, &sshdr)) { sdev_printk(KERN_ERR, sdev, "%s: Found valid sense data 0x%2x, " "0x%2x, 0x%2x while sending CLARiiON trespass " "command.\n", CLARIION_NAME, sshdr.sense_key, -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html