On Mon, 2010-11-15 at 10:28 +0100, Jens Axboe wrote: > >> Third, and most importantly, tags should form an increasing sequence and should not be reused until all other tags after it and before it have been reused. This for example can be accomplished if one were to use > >> find_next_zero_bit() with non-zero "offset", it being the last allocated > >> tag in a modulo the number of tags manner. That is, find_next_zero_bit() > >> could wrap as well as starting from an offset or the caller could implement > >> that via two calls to this function, in blk_queue_start_tag(). > > Care to explain your reasoning? For starvation issues? At least I'm not > aware of any correctness issues in that regard, but doing tag cycling in > this fashion seems like a good idea just to prevent starvation alone by > an ill behaving device. Right, it's the clock algorithm to prevent tag starvation. If you have hands representing the first and last tag and they're never allowed to cross, the device can't starve any tag for too long because eventually it will be the only outstanding command. It's not the only algorithm however. Banging down an ordered tag every 200 or so commands has exactly the same effect. In fact the clock algorithm was what the 53c700 driver used (before it was converted to generic tags) and the ordered tag what aic7xxx uses. Realistically, tag starvation isn't really a problem. It was a known issue for 80s era hardware. I've got some of the oldest drives on the planet and I didn't see a problem when the clock algorithm was removed from 53c700. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
