On Thu, 2010-11-11 at 22:47 -0500, Jeff Garzik wrote: > On 11/11/2010 07:13 PM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger<nab@xxxxxxxxxxxxxxx> > > > > This patch changes ata_scsi_queuecmd_lck() to a host lock less > > ata_scsi_queuecmd() that will disable interrupts internally using > > ap->lock and drops the now legacy host_lock unlock. > > > > Signed-off-by: Nicholas A. Bellinger<nab@xxxxxxxxxxxxxxx> > > --- > > drivers/ata/libata-scsi.c | 14 ++++---------- > > 1 files changed, 4 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c > > index a007c36..9614758 100644 > > --- a/drivers/ata/libata-scsi.c > > +++ b/drivers/ata/libata-scsi.c > > @@ -3173,25 +3173,22 @@ static inline int __ata_scsi_queuecmd(struct scsi_cmnd *scmd, > > * SCSI commands. This creates the overall effect of > > * ATA and ATAPI devices appearing as SCSI devices. > > * > > - * LOCKING: > > - * Releases scsi-layer-held lock, and obtains host lock. > > - * > > The code appears correct but the comment removal is not. > > Locking has not disappeared, and the ATA host lock continues to be obtained. > > My apologies for not reading this comment throughly.. Reinstating in lio-core-2.6.git/lock_less-LLDs-for-38 Thank you! --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
