On Mon, Nov 08, 2010 at 02:48:45PM -0800, Nicholas A. Bellinger wrote: > On Mon, 2010-11-08 at 12:19 -0500, Christoph Hellwig wrote: > > Split out the CDB emulation into it's own file, and refactor it along proper > > boundaries. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > > I think this makes alot sense for the vast majority of the CDB emulation > code, but I think specifically for the handful of PR and ALUA CDB > emulation pieces it does make more sense conceptually (and for the sake > of comments) to keep this code in their respective source files. > > Other than those two cases, I am happy to merge this code. Currently all the code is in target_core_transport.c, so splitting it out is a good first stuff. Further splitting out PR and ALUA helpers and moving them to the specific source files seems like a good idea, though. Btw, I just noticed this only applies without patch 9 applies. You should be able to rebase it yourself, if not I'm happy to resend it. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
