On Mon, 8 Nov 2010 09:33:07 -0500 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > I promised you and James to get back to a throughout review for more > than just the backends. It's still in progress, but here is what I > think is most important: Agreed about all the comments. I complained about similar issues publicly and privately. btw, when I'm back to Japan, I resume to work on the ibmvscsis driver. > - Sort of the the namepspace for both the file names and function > names. I think you reluctantly agreed to do that a while ago anyway, > but I think it's time to bite the bullet now. Please agree on a > common prefix for both function names and modules. I think the > target name in the directory structure is the best one, but I really > don't care too much. The transport_ prefix used in some code is > really misleading, and the se_ in other isn't too helpful either. Agreed. And as I said, we definitely need to fix the module names before the mainline inclusion. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
