On 11/07/2010 03:24 AM, Boaz Harrosh wrote:
Well now isn't that simple? One nit for me though. I would like to see a more scary name for above something like: DEF_SCSI_QCMD_WITH_LOCKING or DEF_SCSI_QCMD_OLD_WAY
I don't have a real preference; whatever the community prefers. Maybe I would suggest DEF_SCSI_QCMD_LOCKER.
Something that calls for a cleanup and removal the first time the driver is touched. Otherwise I think this is the only form that should make it safe for this Kernel. (The rename could be nice also though it is one additional hunk in each driver. Did you use a script to produce this?)
No script; a few vim macros helped a bit. I wanted to actually examine each callsite, to get a feel of the locking scheme, and make sure my change was truly an equivalent-transformation.
Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
