On Wed, 2010-10-27 at 20:43 +0800, Hillf Danton wrote: > There seems info should get freed when error encountered. > > Signed-off-by: Hillf Danton <dhillf@xxxxxxxxx> > --- > > --- a/drivers/scsi/libfc/fc_lport.c 2010-09-13 07:07:38.000000000 +0800 > +++ b/drivers/scsi/libfc/fc_lport.c 2010-10-27 20:35:10.000000000 +0800 > @@ -1707,8 +1707,10 @@ static int fc_lport_els_request(struct f > info->sg = job->reply_payload.sg_list; > > if (!lport->tt.exch_seq_send(lport, fp, fc_lport_bsg_resp, > - NULL, info, tov)) > + NULL, info, tov)) { > + kfree(info); The same comment I made about patch [1/2] applies here. We need the BSG info in the fc_lport_bsg_resp response handler. Thanks, //Rob -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html