On 10/27/2010 08:24 PM, Robert Love wrote:
On Mon, 2010-10-25 at 20:37 +0800, Hillf Danton wrote:There seems frame should get freed against memory leakage. Signed-off-by: Hillf Danton<dhillf@xxxxxxxxx> --- --- a/drivers/scsi/libfc/fc_fcp.c 2010-09-13 07:07:38.000000000 +0800 +++ b/drivers/scsi/libfc/fc_fcp.c 2010-10-25 20:31:04.000000000 +0800 @@ -1294,6 +1294,7 @@ static void fc_tm_done(struct fc_seq *se */ if (!fsp->seq_ptr || !fsp->wait_for_comp) { spin_unlock_bh(&fsp->scsi_pkt_lock);I wonder if this should be a fc_fcp_unlock_pkt(fsp) since we get the lock with the fc_fcp_lock_pkt(fsp) call above.
Did I do that. I think you are right. Not sure what happened if it was me. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
