On 10/26/2010 07:15 PM, Yang, Bo wrote: > James, > > Thanks for correcting that. Did you also applied 2/5, 3/5 and 4/5 patches? > > By the way, I always use checkpatch.pl to check the patch before I attach the patch to the e-mail. Also I just went to the 5/5 patch to verify the patch: the steps: > > 1. go to http://marc.info/?l=linux-scsi&m=128688974201201&w=2 > Looking carefully at the above page (select the text) you can see the trailing whitespaces directly on that page. > 2. click: ["megasas-version.patch" (application/octet-stream)] to download this patch. > 3. Used the checkpatch.pl to check (I used the cmd: "checkpatch.pl --no-tree megasas-version.patch") > > It looks OK for me (no errors). It is maybe the checkpatch.pl I used does not get updated or some steps are not correct. I will find out the updated one to try and find out the reasons. > Use the checkpatch.pl from the scripts directory > > Thanks, > > Bo Yang > > > -----Original Message----- > From: James Bottomley [mailto:James.Bottomley@xxxxxxx] > Sent: Tuesday, October 26, 2010 12:12 PM > To: Yang, Bo > Cc: bo yang; linux-scsi@xxxxxxxxxxxxxxx; akpm@xxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 5/5] scsi: megaraid_sas - Version and documentation update > > On Tue, 2010-10-12 at 07:21 -0600, Yang, Bo wrote: > >> Re-Submit: >> >> Update the version and documentation. >> > This has an impressive set of checkpatch failures: > > ERROR: trailing whitespace > #26: FILE: Documentation/scsi/ChangeLog.megaraid_sas:13: > +^ITo add the OCR support, driver need to do: $ > > ERROR: trailing whitespace > #30: FILE: Documentation/scsi/ChangeLog.megaraid_sas:17: > +^I^I$ > > ERROR: trailing whitespace > #35: FILE: Documentation/scsi/ChangeLog.megaraid_sas:22: > +^I^I$ > > ERROR: trailing whitespace > #39: FILE: Documentation/scsi/ChangeLog.megaraid_sas:26: > +^I^I$ > > ERROR: trailing whitespace > #43: FILE: Documentation/scsi/ChangeLog.megaraid_sas:30: > +^I^I$ > > ERROR: trailing whitespace > #46: FILE: Documentation/scsi/ChangeLog.megaraid_sas:33: > +^I^I $ > > ERROR: trailing whitespace > #48: FILE: Documentation/scsi/ChangeLog.megaraid_sas:35: > +^I^IOCR to see if driver can bring back the FW. $ > > ERROR: trailing whitespace > #54: FILE: Documentation/scsi/ChangeLog.megaraid_sas:41: > +3.^IIn driver's timeout routine, driver will do three time reset if fw > is in $ > > total: 8 errors, 0 warnings, 70 lines checked > > I've fixed it up this time, but could you run it through checkpatch.pl > next time? > > Thanks, > > James > > > NïïïïïrïïyïïïbïXïïÇvï^ï)Þ{.nï+ïïïï{ïïï"ï{ayï ÊÚï,jïïfïïïhïïïzï ïwïïï ïïïj:+vïïïwïjïmïïïïïïïïzZ+ïïÝj"ïï!tml= -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
