On Wed, 2010-10-06 at 17:13 +0800, Jack Wang wrote: > Hi, all > > In SAS2 spec table to table link is allowed and useful in self-configurable > topology, so we should not return error for this. > > Jack So I'm not against this type of patch in principle ... we do need to add support for SAS-2 expanders. However, the table to table configuration is illegal and non-functional for SAS-1 expanders, so we can't just drop it globally; it's also optional in SAS-2 not mandatory. We can tell if an expander supports table to table routing from byte 10 in the report general response ... this type of check should be keyed off that. [As should probably a whole host of other things, such as not trying to construct the routing table if the expander is self configuring]. James Hi James You are right, the right direction is to check the response of REPORT GENERAL to see whether the expander is self-configuring and supports table to table attachment, and check the DISCOVER response to see the routing attribute of each phy when check the topology. But I think this patch is a start point, even in SAS-1 expander we also print some error message to inform the admin to check the topology, and in SAS-2 expander can discover the topology not to hang and give a oops! Thanks! Jack -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
