Re: [PATCH 2/6] bfa: replace endian swap macros with the ones provided by linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 19, 2010 at 01:14:53PM -0700, Jing Huang wrote:
> Thanks for reviewing the patch. I tried sparse endianess checking and saw a lot of warnings, mostly
> because the structure members are still declared as unsigned int instead of using endianess annotated
> types such as __le16, __be16 and etc. Are issues like this must be fixed? I tried some other drivers
> and saw a lot of similar issues also.

Driver relaly should use proper annotations (endiness, __iomem and __user).
This helps catching all kinds of really nasty bugs using the sparse
static analysis tool.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux