On Sat, Oct 02, 2010 at 01:46:21AM +0400, Vladislav Bolkhovitin wrote:
> This patch contains SYSFS interface implementation.
Nice, but you forgot to document it. All sysfs changes need to be
documented in Documentation/ABI/
Please add a file to this patch that does so.
> +static void scst_tgtt_release(struct kobject *kobj)
> +{
> + struct scst_tgt_template *tgtt;
> +
> + tgtt = container_of(kobj, struct scst_tgt_template, tgtt_kobj);
> + complete_all(&tgtt->tgtt_kobj_release_cmpl);
> + return;
Don't you also need to free the memory of your kobject here?
> +static void scst_tgt_release(struct kobject *kobj)
> +{
> + struct scst_tgt *tgt;
> +
> + tgt = container_of(kobj, struct scst_tgt, tgt_kobj);
> + complete_all(&tgt->tgt_kobj_release_cmpl);
> + return;
Same here, no kfree?
> +static void scst_acg_release(struct kobject *kobj)
> +{
> + struct scst_acg *acg;
> +
> + acg = container_of(kobj, struct scst_acg, acg_kobj);
> + complete_all(&acg->acg_kobj_release_cmpl);
And here.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
