On 10/08/2010 03:47 PM, Yang, Bo wrote: > James, > > Thanks for getting the online controller reset in. I downloaded patch 2/5 from http://marc.info/?l=linux-scsi&m=128521127203199&w=2 and I can apply it without errors. > > Can you try it again? otherwise I need to re-attach it. > I've tried it (http://marc.info/?l=linux-scsi&m=128521127203199&w=2) and it is broken. If you look at the end of the patche there should be 3 lines of the original code after the last + sign. tomash Broken: + driver_remove_file(&megasas_pci_driver.driver, &driver_attr_release_date); driver_remove_file(&megasas_pci_driver.driver, &driver_attr_version); -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in Works for me: + driver_remove_file(&megasas_pci_driver.driver, &driver_attr_release_date); driver_remove_file(&megasas_pci_driver.driver, &driver_attr_version); <- this line is missing in your patch -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > Thanks, > > Bo Yang > > -----Original Message----- > From: James Bottomley [mailto:James.Bottomley@xxxxxxx] > Sent: Thursday, October 07, 2010 6:36 PM > To: bo yang > Cc: Yang, Bo; linux-scsi@xxxxxxxxxxxxxxx; akpm@xxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/5] scsi: megaraid_sas - support devices update flag > > On Wed, 2010-09-22 at 22:50 -0400, bo yang wrote: > >> Driver added the Device update flag to tell LSI application driver >> will do the device Update. LSI MegaRAID SAS application will check >> this flag to decide if it is need to update the Device or not. >> > Well, the good news is I've got the Online Controller reset update. The > bad news is that this patch now fails to apply: looks like an attachment > problem again: > > Applying: megaraid_sas: support devices update flag > fatal: corrupt patch at line 70 > Patch failed at 0001 megaraid_sas: support devices update flag > > James > > > NïïïïïrïïyïïïbïXïïÇvï^ï)Þ{.nï+ïïïï{ïïï"ï{ayïÊÚï,jïïfïïïhïïïzïïwïïïïïïj:+vïïïwïjïmïïïïïïïïzZ+ïïÝj"ïï!tml= -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html