On Tue, 2010-10-05 at 16:28 +0200, Oliver Neukum wrote: > From f4eee84ae76a303f8ceca761f0d9e3813b4d45cb Mon Sep 17 00:00:00 2001 > From: Oliver Neukum <oliver@xxxxxxxxxx> > Date: Tue, 5 Oct 2010 16:10:30 +0200 > Subject: [PATCH] SCSI: don't return errors for failures in sd_suspend() > > If an uncoorectable error happens during the suspension > of an sd device, the device is unsalvageable. The error > can be ignored, as offlined devices will be ignored in > the future anyway. More justification please ... Lying to upper layers about errors (or just ignoring them) has been a huge problem with our stack error handling which we are trying to correct. The most likely cause of error is cache sync failure so at the point of power off for suspend, we'll lose data. This might not be an uncorrectable error either; it could be memory allocation failure or a host of other transient reasons. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
