Re: [PATCH] libsas: fix definition of wideport, include local sas address On Sat, Oct 2, 2010 at 6:55 PM, Jack Wang <jack_wang@xxxxxxxxx> wrote: > > To date libsas has only looked at the attached sas address when > determining the formation of wide ports. The specification and some > hardware expects that phys with different addresses will not form a wide > port unless the local peer phys also match each other. Introduce a flag > to select stricter behavior at sas_register_ha() time. The flag can be > dropped once it is known that all libsas users expect the same behavior. > > Current drivers just initialize this field to zero and get the > traditional behavior. > [Jack] I prefer to use the new definition of wideport to the default. Ok, when mvsas and aic94xx are also ready for this change we can just make this the default and kill the flag. > [Jack] I cann't find where to judge the flag to chose which definition to > use? I am not clear on the question. phy_is_wideport_member() should be the only location that needs to read this flag. The driver just sets it to 1 before calling sas_register_ha() and then assumes the strict definition is in effect for the lifetime of the driver instance. [Jack] Ohh, I miss something in the patch. It's ok for me. Thanks for Explanation. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
