Thanks, Mike. I will fix the patch and break it into per change. Karen -----Original Message----- From: Mike Christie [mailto:michaelc@xxxxxxxxxxx] Sent: Wednesday, September 22, 2010 1:10 PM To: Karen Xie Cc: netdev@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; open-iscsi@xxxxxxxxxxxxxxxx; Rakesh Ranjan; James.Bottomley@xxxxxxxxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx Subject: Re: [PATCH] cxgbi: bug fixes and code cleanup On 09/21/2010 11:09 AM, kxie@xxxxxxxxxxx wrote: > [PATCH] cxgbi: bug fixes and code cleanup > > From: Karen Xie<kxie@xxxxxxxxxxx> > > The patch includes the following changes. > - removed un-used code > - renamed alloc_cpl() to alloc_wr(). > - fixed connecting over VLAN. > - updated cxgb4i connection setting and pagepod programming. Could you break up the patch into a patch per change next time? > - read_lock(&csk->callback_lock); > dskb = skb_peek(&csk->receive_queue); > if (!dskb) { > read_unlock(&csk->callback_lock); I think you also have to remove this read_unlock call. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
