On Wed, Sep 15, 2010 at 7:56 AM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > > Hi Vladislav, > > On Tue, Sep 14, 2010 at 06:36:30PM +0400, Vladislav Bolkhovitin wrote: > > Hi All, > > > > Please review this second iteration of the patch set of the new > > (although, perhaps, the oldest) SCSI target framework for Linux SCST > > with a set of dev handlers and 2 target drivers: for local access > > (scst_local) and for Infiniband SRP (srpt). > > > > [ ... ] > > And too many "naked returns", I believe common style is to only have > return for non-void functions. Hello Dmitry, If there is agreement among kernel maintainers that return statements at the end of functions that do not return a value should be avoided, it might be a good idea to let checkpatch complain about such return statements. Currently checkpatch doesn't complain about such return statements. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
