Re: [PATCH] scsi, mptsas : drop scsi_host lock when calling mptsas_qcmd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2010-09-16 at 15:00 -0700, Joe Eykholt wrote:

> 
> It seems to me we can't completely move the host lock down into the
> drivers since its a shared lock between SCSI and the drivers now.
> 
> If we just have SCSI drop the lock and have the LLD reacquire it,
> that may open up a hole that some LLDs might not tolerate.
> It also hurts performance for the LLDs that want to keep
> the lock for the duration of queuecommand() by adding an extra
> unlock/lock.


It may be even better if we can completely drop the lock in
scsi_dispatch_cmd.  The other reason host_lock was taken there was to
serialize the increment and assignment of a scsi command serial number.
So maybe we can make the serial number counter an atomic.

We can just let the driver decide if they need a lock to serialize their
queue command.

Tim


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux